[PATCH] D111051: [mlir][OpenMP] Add support for SIMD modifier

Wed Nov 24 19:15:00 PST 2021

peixin added a comment.

LGTM.

================
Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:691
   if (schedule == omp::ClauseScheduleKind::Static) {
     ompBuilder->applyStaticWorkshareLoop(ompLoc.DL, loopInfo, allocaIP,
                                          !loop.nowait(), chunk);
----------------
The simd modifier info is not passed to `applyStaticWorkshareLoop`. That is, the schedule type of StaticBalancedChunked is not handled and checked. Considering this function is refactored in https://reviews.llvm.org/D114413. Maybe you can merge this patch, and let it to be handled in D114413.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111051/new/

https://reviews.llvm.org/D111051