[PATCH] D114246: [RISCV] Fix a bug in RISCVFrameLowering.

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 24 14:44:31 PST 2021


luismarques added a comment.

Can you describe this issue in more detail, please? I'm not following it at the moment.

We have a dynamic stack change with the `sub sp, sp, a1`.  I don't see any more dynamic changes after that. The test case then does a bunch of BP-relative loads and stores but the BP has the same value as the SP so we could just perform SP-relative accesses... no? Was the BP meant to be copied from the SP before the dynamic SP change?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114246/new/

https://reviews.llvm.org/D114246



More information about the llvm-commits mailing list