[PATCH] D112327: [AArch64] Async unwind - helper functions to decide on CFI emission

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 24 11:51:02 PST 2021


efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64MachineFunctionInfo.cpp:123
+    NeedsUnwindInfo = MF.needsFrameMoves() &&
+                      !MF.getTarget().getMCAsmInfo()->usesWindowsCFI();
+
----------------
It's kind of confusing to have a method called `needsUnwindInfo` that always returns false on Windows.  Maybe name it needsDWARFUnwindInfo or something like that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112327/new/

https://reviews.llvm.org/D112327



More information about the llvm-commits mailing list