[PATCH] D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 24 11:35:21 PST 2021


efriedma added a comment.

This could use a big comment explaining that AArch64LoadStoreOpt can run after PEI, and what that means in terms of the invariants we rely on, and the invariants we need to uphold to preserve unwind info.  I can see what this patch is doing, but it's not obvious this is a comprehensive solution.  Are sp adjustments the only CFI info we need to update?  Does it matter if the load/store we're modifying already has a CFI directive attached to it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114547/new/

https://reviews.llvm.org/D114547



More information about the llvm-commits mailing list