[PATCH] D114460: [fir] Add fir reduction builder

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 24 09:40:48 PST 2021


awarzynski added a comment.

In D114460#3151536 <https://reviews.llvm.org/D114460#3151536>, @kiranchandramohan wrote:

> If `RuntimeCalltestBase` can be factored out into a separate patch, the other patches can be tested or reviewed independently.

I second that. I appreciate that there's a lot of repetition here, but I would really help if this was split into smaller patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114460/new/

https://reviews.llvm.org/D114460



More information about the llvm-commits mailing list