[PATCH] D114355: [DebugInfo] ValueMapper impl for DIArgList should respect RF_IgnoreMissingLocals

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Correct me if I'm wrong, but isn't the point of RF_IgnoreMissingLocals that missing mappings will cause references to be "dropped" without error if it's set, which in the DIArgList scenario corresponds to emitting Undef. The comment above in the unit test says "we also shouldn't reference the unmapped local", and then on the line I've dropped a comment on, the output refers to the unmapped local.



================
Comment at: llvm/unittests/Transforms/Utils/ValueMapperTest.cpp:323
+  EXPECT_EQ(N1AV, ValueMapper(VM).mapValue(*MAV1));
+  EXPECT_EQ(MAV1, ValueMapper(VM, RF_IgnoreMissingLocals).mapValue(*MAV1));
+  EXPECT_FALSE(VM.count(MAV0));
----------------
(Line I'm referring to in main comment)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114355/new/

https://reviews.llvm.org/D114355