[PATCH] D114365: [DebugInfo][6/N][InstrRef] Ignore stack-pointer clobbers on call instructions even more

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

Based on our discussion in D114362 <https://reviews.llvm.org/D114362>, is it not worth preserving the `-experimental-debug-variable-locations=false` path for `llvm/test/DebugInfo/X86/dbg-addr.ll`? Otherwise LGTM.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp:1349
   for (auto L : MTracker->locations()) {
-    // Stack locations can't be clobbered by regmasks.
+    // Stack locations can't be clobbered by regmasks
     if (MTracker->isSpill(L.Idx))
----------------
nit: full stop removed from comment?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114365/new/

https://reviews.llvm.org/D114365