[PATCH] D114362: [DebugInfo][4/N] Adjust x86 location-list tests for instruction referencing

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando added a comment.

Test changes LGTM (just one non-blocking inline question), but wouldn't we want to preserve the `-experimental-debug-variable-locations=false` coverage that these tests are currently (pre-patch) providing too?



================
Comment at: llvm/test/DebugInfo/COFF/register-variables.ll:48
 ; ASM:         #DEBUG_VALUE: f:p <- $esi
-; ASM:         #DEBUG_VALUE: c <- $eax
+; ASM:         #DEBUG_VALUE: c <- undef
 ; ASM:         movl    %eax, %ecx
----------------
Non-blocking question: why do we get `c <- undef` here? The non-instr-ref location `c <- $eax` looks correct AFAICT.


================
Comment at: llvm/test/DebugInfo/X86/basic-block-sections-debug-loclist-4.ll:9
+; CHECK-NEXT: [0x{{[0-9a-f]+}}, 0x{{[0-9a-f]+}}): DW_OP_consts +7, DW_OP_stack_value
+; CHECK-NEXT: [0x{{[0-9a-f]+}}, 0x{{[0-9a-f]+}}): DW_OP_reg0 RAX)
 ; CHECK-NEXT: DW_AT_name	("i")
----------------
Nice!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114362/new/

https://reviews.llvm.org/D114362