[PATCH] D114410: [ObjectYAML/obj2yaml/yaml2obj][MachO] Support indirect symbol table

[Vincent Lee via Phabricator via llvm-commits]

thevinster marked an inline comment as done.
thevinster added inline comments.


================
Comment at: llvm/lib/ObjectYAML/MachOEmitter.cpp:568
+  for (auto data : Obj.LinkEdit.IndirectSymbols)
+    OS.write(reinterpret_cast<const char *>(&data), 4);
+}
----------------
drodriguez wrote:
> If I am not wrong, `llvm::yaml::Hex32` should have the same size as an `uint32_t`. In any case, it might be better to use a `sizeof(llvm::yaml::Hex32::BaseType)` or similar instead of a naked 4 in here.
I like `sizeof(llvm::yaml::Hex32::BaseType)` since it's clearer. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114410/new/

https://reviews.llvm.org/D114410