[PATCH] D114492: [PowerPC][llvm-objdump] enable --symbolize-operands for PowerPC ELF/XCOFF.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/PowerPC/elf-disassemble-symbolize-operands.yaml:7
+# CHECK:       andi. 4, 4, 1
+# CHECK:       li 4, 1
+# CHECK:       b 0x28 <L0>
----------------
Add `-NEXT:`


================
Comment at: llvm/test/tools/llvm-objdump/ELF/PowerPC/elf-disassemble-symbolize-operands.yaml:43
+
+--- !ELF
+FileHeader:
----------------
obj2yaml created test file has many redundant things which are noise, e.g. eh_frame, .note.GNU-stack, STT_FILE. They can all be deleted.

How about using assembly with `llvm-mc -filetype=obj`? The main thing to test is the code sequence which is opaque as the yaml test (`Content`). An assembly test is easier to update.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:981
                           std::unordered_map<uint64_t, std::string> &Labels) {
-  // So far only supports X86.
-  if (!STI->getTargetTriple().isX86())
+  // So far only supports X86 and PowerPC.
+  if (!STI->getTargetTriple().isX86() && !STI->getTargetTriple().isPPC())
----------------
You can order PowerPC before X86 for an alphabetical order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114492/new/

https://reviews.llvm.org/D114492