[PATCH] D114434: [XCOFF] [llvm-readobj] replace binaries with YAMLs (only tests for Symbols)

[ChenZheng via Phabricator via llvm-commits]

shchenz added a comment.

A patch like this should be marked with "NFC" in the title



================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/symbols64.test:94
+# SYMBOL64-NEXT:       Index: 2
+# SYMBOL64-NEXT:       Name: Sun Apr 28 15:56:49 2019
+# SYMBOL64-NEXT:       Type: XFT_CT (0x1)
----------------
Maybe use a meaningful date here?


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/symbols64.test:100
+# SYMBOL64-NEXT:       Index: 3
+# SYMBOL64-NEXT:       Name: IBM XL C for AIX, Version 16.1.0.2
+# SYMBOL64-NEXT:       Type: XFT_CV (0x2)
----------------
We don't need to mention IBM XLC V16.1 now. Please use IBM Open XL instead.


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/symbols64.test:107
+# SYMBOL64-NEXT:     Index: 4
+# SYMBOL64-NEXT:     Name: 
+# SYMBOL64-NEXT:     Value (RelocatableAddress): 0x0
----------------
whitespace at the end?


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/symbols64.test:115
+# SYMBOL64-NEXT:       Index: 5
+# SYMBOL64-NEXT:       SectionLen: 21474836484
+# SYMBOL64-NEXT:       ParameterHashIndex: 0x2
----------------
The length seems not right to me.


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/symbols64.test:134
+# SYMBOL64-NEXT:       Index: 7
+# SYMBOL64-NEXT:       SectionLen: 21474836484
+# SYMBOL64-NEXT:       ParameterHashIndex: 0x2
----------------
Same as above


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/symbols64.test:153
+# SYMBOL64-NEXT:       Index: 9
+# SYMBOL64-NEXT:       SectionLen: 12884901890
+# SYMBOL64-NEXT:       ParameterHashIndex: 0x8
----------------
Same as above


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114434/new/

https://reviews.llvm.org/D114434