[PATCH] D112899: Update fir.insert_on_range syntax to make the range more explicit (NFC)

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

> @mehdi_amini This comment was mainly for any further syntax change in the dialect. This one can go in anytime.

Ah ok, pushing now then.



================
Comment at: flang/include/flang/Optimizer/Dialect/FIROps.td:1997
 
-  let arguments = (ins fir_SequenceType:$seq, AnyType:$val, ArrayAttr:$coor);
+  let arguments = (ins fir_SequenceType:$seq, AnyType:$val, IndexElementsAttr:$coor);
   let results = (outs fir_SequenceType);
----------------
mehdi_amini wrote:
> Actually this change should likely be separated in another revision from the ASM syntax one.
It's too annoying to split up because IndexElementsAttr can't be parsed alone by default, I'll minimize the churn and land this together this time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112899/new/

https://reviews.llvm.org/D112899