[PATCH] D113715: [mlir][ods] AttrOrTypeGen uses Class

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 23 16:04:26 PST 2021


jpienaar added inline comments.


================
Comment at: llvm/include/llvm/ADT/STLExtras.h:1017
 private:
   std::tuple<RangeTs...> Ranges;
 
----------------
Sorry haven't gotten to this review yet. Could we perhaps extract out the changes to ADT into parent change for separate review?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113715/new/

https://reviews.llvm.org/D113715



More information about the llvm-commits mailing list