[PATCH] D113218: [llvm] [Debuginfo] Add cpp-httplib optional dependency.

[Noah Shutty via Phabricator via llvm-commits]

noajshu marked 2 inline comments as done.
noajshu added inline comments.


================
Comment at: llvm/cmake/config-ix.cmake:195-197
+    check_cxx_symbol_exists(CPPHTTPLIB_HTTPLIB_H ${HTTPLIB_HEADER_PATH} HAVE_HTTPLIB_HEADER)
+    check_cxx_symbol_exists(httplib::default_socket_options ${HTTPLIB_HEADER_PATH} HAVE_HTTPLIB_DEFAULT_SOCKET_OPTIONS)
+    check_cxx_symbol_exists(httplib::detail::find_content_type ${HTTPLIB_HEADER_PATH} HAVE_HTTPLIB_FIND_CONTENT_TYPE)
----------------
phosek wrote:
> Why do we need to check all three?
Good point, the additional checks are redundant. I've removed them. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113218/new/

https://reviews.llvm.org/D113218