[PATCH] D113771: [ELF] Support the "read-only" memory region attribute

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: lld/test/ELF/linkerscript/memory-readonly.test:1
+REQUIRES: x86
+
----------------
MaskRay wrote:
> Suggest renaming this to `memory-neg-attr.test`
> 
> We can use this file to test all negative (`!`) attributes, not just readonly.
The test checks both negative and positive cases, so I guess `memory-attr.test` will fit it better.


================
Comment at: lld/test/ELF/linkerscript/memory-readonly.test:30
+  RAM (a!r) : ORIGIN = 0x8000, LENGTH = 0x1000
+  ROM (rx)  : ORIGIN = 0x9000, LENGTH = 0x1000
+}
----------------
MaskRay wrote:
> Optional: can you figure out another memory region to test an attribute other than `!r` in the same test?
I'll check all four supported attributes in the updated test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113771/new/

https://reviews.llvm.org/D113771