[PATCH] D114371: [Flang] Replace notifyMatchFailure with TODO hard failures

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan updated this revision to Diff 389179.
kiranchandramohan edited the summary of this revision.
kiranchandramohan added a comment.
Herald added subscribers: arphaman, mgorny.
Herald added a reviewer: sscalpone.

For fir.select_type revert to using mlir::emiterror.

Adding negative tests using `not` and checking for the error message.
TODO exits with an error in a build without assertion but aborts in a
build with assertions. Abort requires using `not` with the `--crash`
option. The two different usages of `not` is handled by using a custom
command `%not_cmd` which is converted to `not` or `not --crash`
depending on the presence or absence of assertions. Using `llvm-config`
to check the presence of assertions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114371/new/

https://reviews.llvm.org/D114371

Files:
  flang/lib/Optimizer/CodeGen/CodeGen.cpp
  flang/test/CMakeLists.txt
  flang/test/Fir/Todo/boxproc_host.fir
  flang/test/Fir/Todo/dispatch.fir
  flang/test/Fir/Todo/dispatch_table.fir
  flang/test/Fir/Todo/emboxproc.fir
  flang/test/Fir/Todo/end.fir
  flang/test/Fir/Todo/gentypedesc.fir
  flang/test/Fir/Todo/global_len.fir
  flang/test/Fir/Todo/len_param_index.fir
  flang/test/Fir/Todo/select_case_with_character.fir
  flang/test/Fir/Todo/unboxproc.fir
  flang/test/Fir/convert-to-llvm-invalid.fir
  flang/test/lit.cfg.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114371.389179.patch
Type: text/x-patch
Size: 18894 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211123/8447452c/attachment.bin>