[PATCH] D113281: [AArch64][SVE] Generate ASRD instructions for power of 2 signed divides

Peter Waller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 23 04:26:10 PST 2021


peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.

Looks good with one minor suggestion from me.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:13591
+
+  MVT ConstType = VT.getVectorElementType() == MVT::i64 ? MVT::i64 : MVT::i32;
+
----------------
Nit/suggestion: Please add a comment showing the form of the combine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113281/new/

https://reviews.llvm.org/D113281



More information about the llvm-commits mailing list