[PATCH] D113218: [llvm] [Debuginfo] Add cpp-httplib optional dependency.

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: llvm/CMakeLists.txt:396
 
+set(LLVM_ENABLE_CPP_HTTPLIB "ON" CACHE STRING "Use cpp-httplib HTTP server library if available. Can be ON, OFF, or FORCE_ON")
+
----------------
I'd probably just call it `LLVM_ENABLE_HTTPLIB`, you already use `HTTPLIB` elsewhere (for example `HAVE_HTTPLIB_HEADER`).


================
Comment at: llvm/cmake/config-ix.cmake:195-197
+    check_cxx_symbol_exists(CPPHTTPLIB_HTTPLIB_H ${HTTPLIB_HEADER_PATH} HAVE_HTTPLIB_HEADER)
+    check_cxx_symbol_exists(httplib::default_socket_options ${HTTPLIB_HEADER_PATH} HAVE_HTTPLIB_DEFAULT_SOCKET_OPTIONS)
+    check_cxx_symbol_exists(httplib::detail::find_content_type ${HTTPLIB_HEADER_PATH} HAVE_HTTPLIB_FIND_CONTENT_TYPE)
----------------
Why do we need to check all three?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113218/new/

https://reviews.llvm.org/D113218