[PATCH] D111337: [fir] Add array value copy pass

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

I think you haven't updated the revision yet.



================
Comment at: flang/lib/Optimizer/Transforms/ArrayValueCopy.cpp:120
+
+  void collectArrayAccessFrom(mlir::Operation *op, mlir::Value val) {
+    // `val` is defined by an Op, process the defining Op.
----------------
clementval wrote:
> mehdi_amini wrote:
> > I am very concerned about a recursive algorithm on def-use chain: this is a ticking bomb for a stack overflow in the compiler.
> > Can you make this an iterative algorithm with an explicit stack?
> Would it be ok to address this in a follow up patch? I just added a todo right now. 
How to we track that this get addressed though? I'm wary of TODO that will stay here for a while. 
Is someone gonna commit to work on this ASAP? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111337/new/

https://reviews.llvm.org/D111337