[PATCH] D112063: [lld][ELF] Add first bits to support relocation relaxations for AArch64

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 22 19:31:50 PST 2021


MaskRay added inline comments.


================
Comment at: lld/test/ELF/aarch64-adrp-ldr-got.s:102
+L:
+  ldr     x0, [x0, #:got_lo12:x]
----------------
We also miss a case when the GOT entry points to a constant. You can take a look at ppc64-toc-relax-constants.s

I know it is a bit tedious but we really want all conditions to be tested (e.g. `icf-*`), but I do like the split-file style of the file which places all conditions in one file, which is more readable than x86-64-gotpc-relax* and ppc64-toc-relax*


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112063/new/

https://reviews.llvm.org/D112063



More information about the llvm-commits mailing list