[PATCH] D114286: [memprof] Extend llvm-profdata to display MemProf profile summaries.

Snehasish Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 22 13:40:06 PST 2021


snehasish marked an inline comment as done.
snehasish added inline comments.


================
Comment at: llvm/lib/ProfileData/RawMemProfReader.cpp:33
+
+  return Summary{
+      Header->version,
----------------
davidxl wrote:
> This assumes one Header in the profile, but it is possible to have multiple raw profiles concatenated in the same file?
This is just a helper which reads some data from 1 raw profile. Start only needs to point to the beginning of a header (see usage in RawMemProfReader::printSummary). Is there anything you recommend to make this usage clearer?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114286/new/

https://reviews.llvm.org/D114286



More information about the llvm-commits mailing list