[PATCH] D114172: [ARM] implement support for ALU/LDR PC-relative group relocations

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

You can mark comments as "Done". Then when you upload a new revision like `arc diff 'HEAD^'`, the comments will be marked as resolved. Some reviewers want to ensure all comments are resolved.



================
Comment at: lld/test/ELF/arm-adr-err-long.s:3
+// RUN: llvm-mc --triple=armv7a-none-eabi --arm-add-build-attributes -filetype=obj -o %t.o %s
+// RUN: echo "SECTIONS { \
+// RUN:                 .text.0 0x100000 : AT(0x100000) { *(.text.0) } \
----------------
Use `split-file` to avoid complex multi-line echo.


================
Comment at: lld/test/ELF/arm-adr-err-long.s:10
+
+// This is a variant of arm-adr-long.s with some _NC relocs changed into their
+// checking counterparts, to verify that out-of-range references are caught.
----------------
`/// ` to make comments stand out from RUN and CHECK lines.

If you use `# RUN:`, the file can use `## ` for comments.


================
Comment at: lld/test/ELF/arm-adr-err-long.s:66
+ .word 0
+
+
----------------
Delete trailing empty lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114172/new/

https://reviews.llvm.org/D114172