[PATCH] D114389: AArch64 GIsel: legalize lshr operands, even if it is poison

Jameson Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 22 13:01:16 PST 2021


vtjnash created this revision.
Herald added subscribers: hiraditya, kristof.beyls.
vtjnash requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Discovered while trying to build Julia with LLVM v13 (https://github.com/JuliaLang/julia/pull/42602).

While this shift is not defined (returns poison), it should not crash codegen,
as it may appear inside dead code (for example, a select instruction), and it
is legal as long as the value is not used.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114389

Files:
  llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
  llvm/test/CodeGen/AArch64/GlobalISel/select-binop.mir
  llvm/test/CodeGen/AArch64/GlobalISel/select-scalar-shift-imm.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114389.389011.patch
Type: text/x-patch
Size: 6057 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211122/b59e1361/attachment.bin>


More information about the llvm-commits mailing list