[PATCH] D114350: [DwarfCompileUnit] Set parent DIE right after creating a local entity

[Kristina Bessonova via Phabricator via llvm-commits]

krisb added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:524
 // Construct a DIE for this scope.
-void DwarfCompileUnit::constructScopeDIE(
-    LexicalScope *Scope, SmallVectorImpl<DIE *> &FinalChildren) {
+void DwarfCompileUnit::constructScopeDIE(LexicalScope *Scope,
+                                         DIE &ParentScopeDIE) {
----------------
ellis wrote:
> A better name would be `createInlinedScopeDIE()`, but `constructInlinedScopeDIE()` already exists. Should we merge these two functions together? Or maybe we can rename the second to `createInlinedSubprogramDIE()`.
Mmm, I'm not sure it needs renaming. The message in the assert looks a bit confusing, but this function still handles both inlined subprograms and all sorts of lexical block scopes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114350/new/

https://reviews.llvm.org/D114350