[PATCH] D113809: [MachO] Fix struct size assertion

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added a comment.

In D113809#3146954 <https://reviews.llvm.org/D113809#3146954>, @aardappel wrote:

> I tried, but this will take me longer to set up, which I can't do right now. I may be able to return to this later if I am still blocked by it.
>
> I would highly recommend simply not using hardcoded constants like that in portable code however, or to clearly #ifdef whatever platform you are assuming this should be valid for.

There shouldn't be anything platform-specific affecting the size of this struct (and the assertion doesn't fail for me on the MSVC environments I have access to, and I haven't gotten any buildbot failures either), which is why I wanted those details to understand what was different about your environment and why this size assertion wasn't portable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113809/new/

https://reviews.llvm.org/D113809