[PATCH] D114347: [LLD] [COFF] Interpret the immediate in ARM64 adr/adrp relocations as signed 21 bit

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 22 12:07:08 PST 2021


mstorsjo added a comment.

In D114347#3147031 <https://reviews.llvm.org/D114347#3147031>, @efriedma wrote:

> LGTM.  Happy you caught this.  (I think this is consistent with my assembler for adrp.)

Yup, it is consistent with that. In practice, this was harmless at least when linking code generated by LLVM, as I think it never generated any negative offsets here - but it makes it clear that we can only use a range of up to +1 MB, not 2.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114347/new/

https://reviews.llvm.org/D114347



More information about the llvm-commits mailing list