[PATCH] D113442: [InstCombine] Enable fold select into operand for FAdd, FMul, FSub and FDiv.

Mon Nov 22 11:49:21 PST 2021

nlopes added a comment.

In D113442#3146921 <https://reviews.llvm.org/D113442#3146921>, @huihuiz wrote:

> Thanks Sanjay for the review! 
> I did another local run for fadd, with "--disable-undef-input" it finish within a minute. 
> When removing "--disable-undef-input", it's taking about an hour now, still not finished.
>
> Probably, the problem is the floating-point type. We hit some limitations of alive2 I assume.

Reasoning about floats is already quite expensive, and mixing that with undefs is really hard.
The fact it doesn't find any bug within 1 hour is a good sign though. Right now there's nothing better we can do. We have plans to improve this in the longer term.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113442/new/

https://reviews.llvm.org/D113442