[PATCH] D112852: [GlobalISel] Allow DBG_VALUE to use invalid vregs throughout pipeline

[Matthias Braun via Phabricator via llvm-commits]

MatzeB requested changes to this revision.
MatzeB added a comment.
This revision now requires changes to proceed.

Requesting changes for the missing MIR serialization of the new property.

> The issue here is determining where the barrier for disallowing these undefined vregs should be. LiveDebugVariables naturally discards these particular uses, so this is sufficient based on my knowledge.

Well to me this feels like we are making the intermediate representation more complicated (I consider it more complicated because DBG_VALUE instructions are special with lifetime rules now) for a very small gain.

That said I don't feel strongly about this. If others think this is benefitial then we can go ahead.



================
Comment at: llvm/include/llvm/CodeGen/MachineFunction.h:166
     FailsVerification,
-    LastProperty = FailsVerification,
+    DebugValuesAllocated,
+    LastProperty = DebugValuesAllocated,
----------------
New properties must be added to MIRYamlMapping.h / MIRParser.cpp


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112852/new/

https://reviews.llvm.org/D112852