[PATCH] D88827: [llvm-objcopy][NFC] Move core implementation of llvm-objcopy into separate library.

[Alexey Lapshin via Phabricator via llvm-commits]

avl updated this revision to Diff 388956.
avl added a comment.

addressed comments:

1. deleted doc comments(will add them with the follow-up patch).
2. moved methods implementation into .cpp file.
3. optimized headers.
4. did not modify cmake to create IDE folders(will do it with the follow-up patch).
5. added traces in the test assertions.
6. rewrote test to use inmemory output file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88827/new/

https://reviews.llvm.org/D88827

Files:
  llvm/include/llvm/Object/ObjCopy/COFF/COFFConfig.h
  llvm/include/llvm/Object/ObjCopy/COFF/COFFObjcopy.h
  llvm/include/llvm/Object/ObjCopy/CommonConfig.h
  llvm/include/llvm/Object/ObjCopy/ConfigManager.h
  llvm/include/llvm/Object/ObjCopy/ELF/ELFConfig.h
  llvm/include/llvm/Object/ObjCopy/ELF/ELFObjcopy.h
  llvm/include/llvm/Object/ObjCopy/MachO/MachOConfig.h
  llvm/include/llvm/Object/ObjCopy/MachO/MachOObjcopy.h
  llvm/include/llvm/Object/ObjCopy/MultiFormatConfig.h
  llvm/include/llvm/Object/ObjCopy/ObjCopy.h
  llvm/include/llvm/Object/ObjCopy/wasm/WasmConfig.h
  llvm/include/llvm/Object/ObjCopy/wasm/WasmObjcopy.h
  llvm/lib/Object/CMakeLists.txt
  llvm/lib/Object/ObjCopy/COFF/COFFObjcopy.cpp
  llvm/lib/Object/ObjCopy/COFF/Object.cpp
  llvm/lib/Object/ObjCopy/COFF/Object.h
  llvm/lib/Object/ObjCopy/COFF/Reader.cpp
  llvm/lib/Object/ObjCopy/COFF/Reader.h
  llvm/lib/Object/ObjCopy/COFF/Writer.cpp
  llvm/lib/Object/ObjCopy/COFF/Writer.h
  llvm/lib/Object/ObjCopy/ConfigManager.cpp
  llvm/lib/Object/ObjCopy/ELF/ELFObjcopy.cpp
  llvm/lib/Object/ObjCopy/ELF/Object.cpp
  llvm/lib/Object/ObjCopy/ELF/Object.h
  llvm/lib/Object/ObjCopy/MachO/MachOLayoutBuilder.cpp
  llvm/lib/Object/ObjCopy/MachO/MachOLayoutBuilder.h
  llvm/lib/Object/ObjCopy/MachO/MachOObjcopy.cpp
  llvm/lib/Object/ObjCopy/MachO/MachOReader.cpp
  llvm/lib/Object/ObjCopy/MachO/MachOReader.h
  llvm/lib/Object/ObjCopy/MachO/MachOWriter.cpp
  llvm/lib/Object/ObjCopy/MachO/MachOWriter.h
  llvm/lib/Object/ObjCopy/MachO/Object.cpp
  llvm/lib/Object/ObjCopy/MachO/Object.h
  llvm/lib/Object/ObjCopy/ObjCopy.cpp
  llvm/lib/Object/ObjCopy/wasm/Object.cpp
  llvm/lib/Object/ObjCopy/wasm/Object.h
  llvm/lib/Object/ObjCopy/wasm/Reader.cpp
  llvm/lib/Object/ObjCopy/wasm/Reader.h
  llvm/lib/Object/ObjCopy/wasm/WasmObjcopy.cpp
  llvm/lib/Object/ObjCopy/wasm/Writer.cpp
  llvm/lib/Object/ObjCopy/wasm/Writer.h
  llvm/tools/llvm-objcopy/CMakeLists.txt
  llvm/tools/llvm-objcopy/COFF/COFFConfig.h
  llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp
  llvm/tools/llvm-objcopy/COFF/COFFObjcopy.h
  llvm/tools/llvm-objcopy/COFF/Object.cpp
  llvm/tools/llvm-objcopy/COFF/Object.h
  llvm/tools/llvm-objcopy/COFF/Reader.cpp
  llvm/tools/llvm-objcopy/COFF/Reader.h
  llvm/tools/llvm-objcopy/COFF/Writer.cpp
  llvm/tools/llvm-objcopy/COFF/Writer.h
  llvm/tools/llvm-objcopy/CommonConfig.h
  llvm/tools/llvm-objcopy/ConfigManager.cpp
  llvm/tools/llvm-objcopy/ConfigManager.h
  llvm/tools/llvm-objcopy/ELF/ELFConfig.h
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.h
  llvm/tools/llvm-objcopy/ELF/Object.cpp
  llvm/tools/llvm-objcopy/ELF/Object.h
  llvm/tools/llvm-objcopy/MachO/MachOConfig.h
  llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.cpp
  llvm/tools/llvm-objcopy/MachO/MachOLayoutBuilder.h
  llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
  llvm/tools/llvm-objcopy/MachO/MachOObjcopy.h
  llvm/tools/llvm-objcopy/MachO/MachOReader.cpp
  llvm/tools/llvm-objcopy/MachO/MachOReader.h
  llvm/tools/llvm-objcopy/MachO/MachOWriter.cpp
  llvm/tools/llvm-objcopy/MachO/MachOWriter.h
  llvm/tools/llvm-objcopy/MachO/Object.cpp
  llvm/tools/llvm-objcopy/MachO/Object.h
  llvm/tools/llvm-objcopy/MultiFormatConfig.h
  llvm/tools/llvm-objcopy/ObjcopyOptions.cpp
  llvm/tools/llvm-objcopy/ObjcopyOptions.h
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.h
  llvm/tools/llvm-objcopy/wasm/Object.cpp
  llvm/tools/llvm-objcopy/wasm/Object.h
  llvm/tools/llvm-objcopy/wasm/Reader.cpp
  llvm/tools/llvm-objcopy/wasm/Reader.h
  llvm/tools/llvm-objcopy/wasm/WasmConfig.h
  llvm/tools/llvm-objcopy/wasm/WasmObjcopy.cpp
  llvm/tools/llvm-objcopy/wasm/WasmObjcopy.h
  llvm/tools/llvm-objcopy/wasm/Writer.cpp
  llvm/tools/llvm-objcopy/wasm/Writer.h
  llvm/unittests/Object/CMakeLists.txt
  llvm/unittests/Object/ObjCopyTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88827.388956.patch
Type: text/x-patch
Size: 165774 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211122/eeb6e34e/attachment-0001.bin>