[PATCH] D110040: [lld-macho] Don't replace local personality symbol with LazySymbol

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 22 09:09:57 PST 2021


int3 added a comment.

Sorry, too many half-baked things in my diff queue, missed this on Friday :)



================
Comment at: lld/test/MachO/objc-uses-custom-personality.s:1
+## Tests that lld correctly resolves the custom personality referenced by objc code in an archive.
+
----------------
the "objc" part seems tangential to the logic actually being tested, no? can we make the test non-objc-specific?


================
Comment at: lld/test/MachO/objc-uses-custom-personality.s:5
+# RUN: rm -rf %t; split-file %s %t
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-iossimulator  %t/defined.s -o %t/defined.o
+# RUN: yaml2obj %t/combined.yaml > %t/combined.o
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110040/new/

https://reviews.llvm.org/D110040



More information about the llvm-commits mailing list