[PATCH] D114078: [X86] Add tests cases for or-lea with no common bits.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 22 08:51:56 PST 2021


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/or-lea.ll:154
+  ret i16 %inc
+}
+
----------------
OmerAviram wrote:
> RKSimon wrote:
> > Why have you used i16? That is the one type that x86 will try very hard to promote to i32/64 for a shorter encoding and to break partial register dependencies.
> I see, thanks. Any suggestion for a type better suited for those tests?
Probably a mixture of i32 and i64 tests?

Also, please don't just number tests - try to give them descriptive names like most of these existing tests in this file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114078/new/

https://reviews.llvm.org/D114078



More information about the llvm-commits mailing list