[PATCH] D114146: [DA][NFC] Update publication - add remarks
Simon Moll via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 22 01:04:34 PST 2021
simoll added a comment.
In D114146#3144499 <https://reviews.llvm.org/D114146#3144499>, @sameerds wrote:
> In D114146#3142269 <https://reviews.llvm.org/D114146#3142269>, @simoll wrote:
>
>> All good points. PDT and the comment on strict loop compactness are leftovers. I will remove PDT in a followup patch.
>
> So will you be rephrasing the compactness in this patch? While I am convinced that it does not affect correctness, I have not thought about whether it affects accuracy, i.e., whether the lack of compactness may result in some places being marked divergent when they aren't.
I won't touch the comment on loop compactness in this patch. The change does modify how we think about this, which shouldn't happen in the same commit as an updated reference.
Giving up loop compactness (not the order constraints on the loop header/exits though!) shouldn't even change the result of the analysis tbh.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114146/new/
https://reviews.llvm.org/D114146
More information about the llvm-commits
mailing list