[PATCH] D112450: support xcoff for llvm-nm

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 22 00:42:59 PST 2021


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/XCOFF/basic.test:24-25
+# NM-SYM-NEXT: 00000000 t .text
+
+# NM-SYM:      00000104 d _Z5func1i
+# NM-SYM-NEXT: 0000010c D _Z5func1i
----------------
Why are you not using check-next here? Are there symbols you are deliberately ignoring in this case?


================
Comment at: llvm/test/tools/llvm-nm/XCOFF/basic.test:31
+# NM-SYM-NEXT: 0000011c W weak_value
+~
----------------
Why's this line here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112450/new/

https://reviews.llvm.org/D112450



More information about the llvm-commits mailing list