[PATCH] D114013: [ARM] Fold away unnecessary CSET/CMPZ

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 22 00:06:26 PST 2021


dmgreen added a comment.

In D114013#3139605 <https://reviews.llvm.org/D114013#3139605>, @SjoerdMeijer wrote:

> First a high-level, perhaps silly question: could we do this simplification earlier? If this is the result of expanding vector operations, could we this where the expansion happens? Or is this the best place to do this?

I think this is the most general place for it. It captures several places this can come from.

I have some other related CSINC/CSINV patterns to upload too, they are just tablegen patterns. In the process of creating them I was wondering if we should be removing the CSINC/CSINV/CSNEG node types and use CMOV for everything, selecting from them. That would be a larger job though, and would likely need something like this anyway.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114013/new/

https://reviews.llvm.org/D114013



More information about the llvm-commits mailing list