[PATCH] D114289: [AMDGPU] Remove a no-op check in the gfx90a hazard recognizer

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 19 14:46:41 PST 2021


rampitec updated this revision to Diff 388636.
rampitec edited the summary of this revision.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114289/new/

https://reviews.llvm.org/D114289

Files:
  llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp


Index: llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
+++ llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
@@ -1442,12 +1442,10 @@
     bool FullReg;
     const MachineInstr *MI1;
 
-    auto IsOverlappedDGEMMorXDLFn = [Reg, &IsMFMAFn, &FullReg, &MI1,
-                                     this](const MachineInstr &MI) {
+    auto IsOverlappedMFMAFn = [Reg, &IsMFMAFn, &FullReg, &MI1, this]
+                              (const MachineInstr &MI) {
       if (!IsMFMAFn(MI))
         return false;
-      if (!isDGEMM(MI.getOpcode()) && !isXDL(ST, MI))
-        return false;
       Register DstReg = MI.getOperand(0).getReg();
       FullReg = (DstReg == Reg);
       MI1 = &MI;
@@ -1458,7 +1456,7 @@
       getWaitStatesSinceDef(Reg, IsLegacyVALUNotDotFn, MaxWaitStates);
     WaitStatesNeeded = std::max(WaitStatesNeeded, WaitStatesNeededForUse);
 
-    int NumWaitStates = getWaitStatesSinceDef(Reg, IsOverlappedDGEMMorXDLFn,
+    int NumWaitStates = getWaitStatesSinceDef(Reg, IsOverlappedMFMAFn,
                                               MaxWaitStates);
     if (NumWaitStates == std::numeric_limits<int>::max())
       continue;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114289.388636.patch
Type: text/x-patch
Size: 1259 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211119/6adc2b6e/attachment-0001.bin>


More information about the llvm-commits mailing list