[PATCH] D114341: llvm: Allow the cmake 'NONE' release type

orbea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 21 15:03:53 PST 2021


orbea created this revision.
orbea added a reviewer: kazu.
Herald added a subscriber: mgorny.
orbea requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Most cmake projects allow a NONE CMAKE_RELEASE_TYPE which is equivalent to plain in meson. This PR adds to llvm/CMakeLists.txt so the build doesn't error.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114341

Files:
  llvm/CMakeLists.txt


Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -277,7 +277,7 @@
 string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
 
 if (CMAKE_BUILD_TYPE AND
-    NOT uppercase_CMAKE_BUILD_TYPE MATCHES "^(DEBUG|RELEASE|RELWITHDEBINFO|MINSIZEREL)$")
+    NOT uppercase_CMAKE_BUILD_TYPE MATCHES "^(NONE|DEBUG|RELEASE|RELWITHDEBINFO|MINSIZEREL)$")
   message(FATAL_ERROR "Invalid value for CMAKE_BUILD_TYPE: ${CMAKE_BUILD_TYPE}")
 endif()
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114341.388773.patch
Type: text/x-patch
Size: 537 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211121/251db231/attachment.bin>


More information about the llvm-commits mailing list