[PATCH] D113086: [flang] Add a semantics test for co_reduce

Emil Kieri via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 21 12:55:14 PST 2021


ekieri added inline comments.


================
Comment at: flang/test/Semantics/collectives05.f90:41
+    ! the error is seen as too many arguments to the co_reduce() call
+    !ERROR: too many actual arguments for intrinsic 'co_reduce'
+    call co_reduce(i, int_op, result_image=1, stat=status, errmsg=message, 3.4)
----------------
Please start error messages with a captial letter, as per [1]. (I suppose that overrides [2], which requires the opposite.) Same things on line 45. 

[1] https://flang.llvm.org/docs/C++style.html#error-messages
[2] https://llvm.org/docs/CodingStandards.html#error-and-warning-messages


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113086/new/

https://reviews.llvm.org/D113086



More information about the llvm-commits mailing list