[PATCH] D114327: [CMake] Installable find modules for terminfo and libffi

Jack Andersen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 20 14:58:53 PST 2021


jackoalan created this revision.
jackoalan added a reviewer: chandlerc.
Herald added subscribers: hiraditya, mgorny.
jackoalan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Improves cross-distro portability of LLVM cmake package by resolving paths for terminfo and libffi via import targets.

When `LLVMExports.cmake` is generated for installation, it contains hard-coded library and include paths which are likely to be a common cause of portability issues. To mitigate this, the discovery logic for these dependencies is refactored into find modules which get installed alongside `LLVMConfig.cmake`. The result is cleaner, cmake-friendly management of these dependencies that respect the environment of the LLVM package importer.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D114327

Files:
  llvm/cmake/config-ix.cmake
  llvm/cmake/modules/FindFFI.cmake
  llvm/cmake/modules/FindTerminfo.cmake
  llvm/cmake/modules/LLVMConfig.cmake.in
  llvm/lib/ExecutionEngine/Interpreter/CMakeLists.txt
  llvm/lib/Support/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114327.388733.patch
Type: text/x-patch
Size: 8856 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211120/9a4f3da0/attachment.bin>


More information about the llvm-commits mailing list