[PATCH] D114307: [Demangle] Add support for D anonymous symbols

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 20 13:19:54 PST 2021


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks OK, though the "anonymous" in the mangled name tests seems misleading - the "anonymous" isn't itself, anonymous, right? IT's followed by anonymous symbol (`0`), yeah? So maybe change that text/name - might be clearer.

Alternatively, wouldn't this fall out naturally from `parseIdentifier` if `parseIdentifier` returned `Mangled` (rather than `nullptr`) when `Len == 0`? Seems that'd be simpler/tidier?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114307/new/

https://reviews.llvm.org/D114307



More information about the llvm-commits mailing list