[PATCH] D114305: [Demangle] Add support for multiple identifiers in D qualified names

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good, thanks!



================
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:200-203
+  size_t N = 0;
+  do {
+    if (N++)
+      *Demangled << '.';
----------------
Might be more legible to write this as:
```
bool First = true;
do {
  if (First)
    *Demangled << '.';
  First = false;
  Mangled = parseIdentifier...
```
Rather than incrementing `N` which is rather non-descript.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114305/new/

https://reviews.llvm.org/D114305