[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.
James Farrell via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 20 07:33:13 PST 2021
jamesfarrell added inline comments.
================
Comment at: clang/test/Sema/attr-availability-android.c:8
#ifdef WARN_PARTIAL
-// expected-note-re at +2 {{'f3' has been marked as being introduced in Android 19 here, but the deployment target is Android 16.0.0{{$}}}}
+// expected-note-re at +2 {{'f3' has been marked as being introduced in Android 19 here, but the deployment target is Android 16{{$}}}}
#endif
----------------
Observation for reviewers: This is the message we wanted to fix that was the motivation for this change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114163/new/
https://reviews.llvm.org/D114163
More information about the llvm-commits
mailing list