[PATCH] D107087: Fix SectionMemoryManager deconstruction error with MSVC

[Lang Hames via Phabricator via llvm-commits]

lhames added a comment.

Sorry for the delayed reply.

> @lhames When you say "original fix" do you mean the fix where I moved DefaultMMapper to be a member of SectionMemoryManager?

Yep. But I think anything that fixes this issue without unreasonable overhead is fine. As I said -- this is more-or-less legacy at this point.

The new approach looks ok too, but we don't allow SectionMemoryManagers to be copied so I think this could just as easily be a unique_ptr, couldn't it?

- Lang.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107087/new/

https://reviews.llvm.org/D107087