[PATCH] D114275: [lld-macho] Include Objective-C functions in LC_FUNCTION_STARTS

[Vincent Lee via Phabricator via llvm-commits]

thevinster added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:800
+
+  for (const InputFile *file : inputFiles) {
+    if (auto *objFile = dyn_cast<ObjFile>(file)) {
----------------
keith wrote:
> oontvoo wrote:
> > keith wrote:
> > > oontvoo wrote:
> > > > Do you happen to have performance data for this change?
> > > > seems like it could take a hit here , esp. for cases where the number of input files is large - ie., most of our apps :) 
> > > > 
> > > > On the other hand, I agree debug experience is important... 
> > > > 
> > > I've haven't tested this on our large links yet so I'll have to check, I agree, I felt bad writing this
> > How would people feel about making this configurable? ( either via making up some new flag or grouping it into an existing one)
> Maybe -no-function-starts is enough for this level of configuration? We actually have that enabled today for our builds for binary size.
Hmm... I think we can parallelize this. This might offset the need to gate it behind a flag. Although, we can hold off on this until more concrete data on how bad this affects the link speed. 

Why can't we add these symbols to the symtab?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114275/new/

https://reviews.llvm.org/D114275