[PATCH] D114275: [lld-macho] Include Objective-C functions in LC_FUNCTION_STARTS

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 19 17:00:27 PST 2021


keith added inline comments.


================
Comment at: lld/MachO/SyntheticSections.cpp:800
+
+  for (const InputFile *file : inputFiles) {
+    if (auto *objFile = dyn_cast<ObjFile>(file)) {
----------------
oontvoo wrote:
> Do you happen to have performance data for this change?
> seems like it could take a hit here , esp. for cases where the number of input files is large - ie., most of our apps :) 
> 
> On the other hand, I agree debug experience is important... 
> 
I've haven't tested this on our large links yet so I'll have to check, I agree, I felt bad writing this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114275/new/

https://reviews.llvm.org/D114275



More information about the llvm-commits mailing list