[PATCH] D114211: [llvm-diff] Implement diff of PHI nodes

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good - optional test change.



================
Comment at: llvm/test/tools/llvm-diff/phinode.ll:2
+; RUN: rm -f %t.ll
+; RUN: cat %s | sed -e 's/%7 = phi i32 \[ 0, %2 \], \[ -1, %1 \]/%7 = phi i32 [ 1, %2 ], [ -1, %1 ]/' > %t.ll
+; RUN: not llvm-diff %s %t.ll 2>&1 | FileCheck %s
----------------
To avoid all the escaping which maybe obscures the purpose of the replacement, maybe this could be `s/ 0,/ 1,/` - yeah, means it /could/ match other parts of the IR, but it doesn't currently at least.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114211/new/

https://reviews.llvm.org/D114211