[PATCH] D109860: profi - a flow-based profile inference algorithm: Part I (out of 3)

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 19 09:21:50 PST 2021


wenlei accepted this revision.
wenlei added a comment.

lgtm except some comment nits, thanks



================
Comment at: llvm/include/llvm/Transforms/Utils/SampleProfileInference.h:108
+
+  /// Bla
+  bool isExit(const BasicBlockT *BB);
----------------
same here. 


================
Comment at: llvm/include/llvm/Transforms/Utils/SampleProfileInference.h:273
+
+/// Bla
+template <typename BT>
----------------
nit, fix comment? same for line 278


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109860/new/

https://reviews.llvm.org/D109860



More information about the llvm-commits mailing list