[PATCH] D113613: [ThinLTO][MC] Use conditional assignments for promotion aliases

Sami Tolvanen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 19 08:54:24 PST 2021


samitolvanen marked an inline comment as done.
samitolvanen added inline comments.


================
Comment at: llvm/test/MC/ELF/set-conditional.s:4
+// RUN:         FileCheck %s --check-prefix=ERR
+
+// CHECK: .set b, a
----------------
MaskRay wrote:
> It is unclear what `.set_conditional` are passed through.
Yes, it's a bit unclear because these are intentionally not emitted in the same order as the `.set_conditional` directives. Emitted `a` leads to the `b` assignment being emitted, which leads to the `c` assignment being emitted, for example. I reordered the checks to hopefully clarify this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113613/new/

https://reviews.llvm.org/D113613



More information about the llvm-commits mailing list