[PATCH] D114035: [DSE] Improve handling of `strncpy` in Dead Store Elimination
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 19 08:19:59 PST 2021
fhahn added a comment.
In D114035#3142607 <https://reviews.llvm.org/D114035#3142607>, @fwolff wrote:
> @fhahn Fixed and rebased, thanks for the review! (And I'll need someone to commit this for me. You can use name and email as in commit `6259016361345e09f0607ef4e037e00bcbe4bd40` for attribution. Thanks!)
>
>> Are you planning on also adding support for other `*n*` variants of library calls?
>
> Which ones are you thinking of in particular? `strncpy` is the "easy" one because it always writes exactly //n// bytes, but I can have a look at some others as well.
I committed the tests separately in ffe1741b5ccab07cbf45fe99033e4119688eb5a5 <https://reviews.llvm.org/rGffe1741b5ccab07cbf45fe99033e4119688eb5a5>. Could you rebase the patch on top of that change?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114035/new/
https://reviews.llvm.org/D114035
More information about the llvm-commits
mailing list