[PATCH] D114174: [WIP][RFC][CodeGen] Add support for complex multiplication

Nicholas Guy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 19 02:29:30 PST 2021


NickGuy updated this revision to Diff 388438.
NickGuy added a comment.

In D114174#3142048 <https://reviews.llvm.org/D114174#3142048>, @SjoerdMeijer wrote:

> Nice one Nick. 
> Can you first run clang-format on this patch? It is pretty much unreadable with all these lint messages.

Hmm, looks like my pre-commit hook isn't working anymore, that's disappointing, Should be formatted now though.
Thanks for spreading the word on this too.

Some context for everyone else, this is a prototype of a potential approach for implementing complex number support. Reviews about the general approach, rather than specific implementation details, would be preferred at this stage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114174/new/

https://reviews.llvm.org/D114174

Files:
  llvm/include/llvm/Analysis/TargetTransformInfo.h
  llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
  llvm/include/llvm/CodeGen/ComplexArithmeticPass.h
  llvm/include/llvm/CodeGen/Passes.h
  llvm/include/llvm/InitializePasses.h
  llvm/lib/Analysis/TargetTransformInfo.cpp
  llvm/lib/CodeGen/CMakeLists.txt
  llvm/lib/CodeGen/ComplexArithmeticPass.cpp
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64ISelLowering.h
  llvm/lib/Target/AArch64/AArch64TargetMachine.cpp
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.h
  llvm/lib/Target/ARM/ARMTargetMachine.cpp
  llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
  llvm/lib/Target/ARM/ARMTargetTransformInfo.h
  llvm/test/CodeGen/AArch64/O3-pipeline.ll
  llvm/test/CodeGen/ARM/complex-arithmetic-arm.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114174.388438.patch
Type: text/x-patch
Size: 63927 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211119/3df67e34/attachment.bin>


More information about the llvm-commits mailing list