[PATCH] D114148: [fir] Add fircg.ext_embox conversion
Kiran Chandramohan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 19 02:02:45 PST 2021
kiranchandramohan added inline comments.
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1666
+ } else if (seqEleTy.isa<fir::RecordType>()) {
+ return rewriter.notifyMatchFailure(
+ xbox,
----------------
Please replace back with TODO.
See discussion in https://reviews.llvm.org/D114104#inline-1089507
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1670
+ } else {
+ return rewriter.notifyMatchFailure(xbox, "unexpected dynamic type");
+ }
----------------
Not sure about this one since it was not a TODO. But please see the following discussion.
https://reviews.llvm.org/D114104#inline-1089507
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1775
+ return rewriter.notifyMatchFailure(
+ xbox, "fir.embox codegen dynamic size component in derived type "
+ "not implemented yet");
----------------
Please replace back with TODO.
See discussion in https://reviews.llvm.org/D114104#inline-1089507
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1787
+ if (isDerivedTypeWithLenParams(boxTy))
+ return rewriter.notifyMatchFailure(
+ xbox, "fir.embox codegen of derived with length parameters not "
----------------
Please replace back with TODO.
See discussion in https://reviews.llvm.org/D114104#inline-1089507
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114148/new/
https://reviews.llvm.org/D114148
More information about the llvm-commits
mailing list